Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user table CSS #2308

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix user table CSS #2308

merged 1 commit into from
Jan 12, 2024

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 2, 2024

Fix CSS highlighting bug in the user table. Compare https://dmoj.ca/users/#!BalintR with https://dmoj.ca/users/#!zhouzixiang2004

Decrease the CSS specificity of the row stripes. This allows the yellow highlight to take priority.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19e7a09) 46.84% compared to head (27f0c6e) 46.84%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2308   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files         250      250           
  Lines       13275    13275           
=======================================
  Hits         6219     6219           
  Misses       7056     7056           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene added this pull request to the merge queue Jan 12, 2024
Merged via the queue into DMOJ:master with commit 61318c7 Jan 12, 2024
3 checks passed
@int-y1 int-y1 deleted the fix-user-table branch January 13, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants