An error response with any error code other than ResponseNotReady shall re-initialize L1/L2 to null.

[Zhiqiang520]

An error response with any error code other than ResponseNotReady shall re-initialize L1/L2 to null.

1. Refer to the paragraph 432 in DSP0274_1.2.1.pdf.
   
2. So I think in libspdm_get_response_measurements function, should call libspdm_reset_message_m(spdm_context, session_info); before return any libspdm_generate_error_response other than ResponseNotReady error.
3. the Requester issues a number of requests without requiring signatures followed by a final request requiring a signature over the entire set of request-response messages exchanged.

GET_MEASUREMENTS_REQUEST1
MEASUREMENTS_RESPONSE1
GET_MEASUREMENTS_REQUEST2
MEASUREMENTS_RESPONSE2
... ...
GET_MEASUREMENTS_REQUESTn
MEASUREMENTS_RESPONSEn

4. In the above scenario, if MEASUREMENTS_RESPONSE1 successful, but MEASUREMENTS_RESPONSE2 error at the following line 364 or 372, then should call libspdm_reset_message_m(spdm_context, session_info); before return libspdm_generate_error_response.
   

   libspdm/library/spdm_responder_lib/libspdm_rsp_measurements.c

   Lines 362 to 375 in 83cbb2f

   	status = libspdm_append_message_m(spdm_context, session_info, spdm_request, request_size);
   	if (LIBSPDM_STATUS_IS_ERROR(status)) {
   	return libspdm_generate_error_response(spdm_context,
   	SPDM_ERROR_CODE_UNSPECIFIED, 0,
   	response_size, response);
   	}
   	status = libspdm_append_message_m(spdm_context, session_info,
   	spdm_response, *response_size - signature_size);
   	if (LIBSPDM_STATUS_IS_ERROR(status)) {
   	return libspdm_generate_error_response(spdm_context,
   	SPDM_ERROR_CODE_UNSPECIFIED, 0,
   	response_size, response);
   	}

5. there are many same issues is in libspdm_rsp_measurements.c, for example,
   

   libspdm/library/spdm_responder_lib/libspdm_rsp_measurements.c

   Lines 95 to 107 in 83cbb2f

   	if (!libspdm_is_capabilities_flag_supported(
   	spdm_context, false, 0,
   	SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_MEAS_CAP)) {
   	return libspdm_generate_error_response(
   	spdm_context, SPDM_ERROR_CODE_UNSUPPORTED_REQUEST,
   	SPDM_GET_MEASUREMENTS, response_size, response);
   	}
   	if ((spdm_context->connection_info.algorithm.measurement_spec == 0) ||
   	(spdm_context->connection_info.algorithm.measurement_hash_algo == 0) ) {
   	return libspdm_generate_error_response(
   	spdm_context, SPDM_ERROR_CODE_UNEXPECTED_REQUEST,
   	0, response_size, response);
   	}

6. there are also many similar issues in libspdm_req_get_measurements.c, for example, the line 414~415,
   

   libspdm/library/spdm_requester_lib/libspdm_req_get_measurements.c

   Lines 411 to 424 in 83cbb2f

   	status = libspdm_append_message_m(spdm_context, session_info, spdm_request,
   	spdm_request_size);
   	if (LIBSPDM_STATUS_IS_ERROR(status)) {
   	status = LIBSPDM_STATUS_BUFFER_FULL;
   	goto receive_done;
   	}
   	status = libspdm_append_message_m(spdm_context, session_info, spdm_response,
   	spdm_response_size - signature_size);
   	if (LIBSPDM_STATUS_IS_ERROR(status)) {
   	libspdm_reset_message_m(spdm_context, session_info);
   	status = LIBSPDM_STATUS_BUFFER_FULL;
   	goto receive_done;
   	}

[jyao1]

Please help check if M1/M2 has similar issue.

[Zhiqiang520]

Please help check if M1/M2 has similar issue.

a. After checking I found one new issue about set M1/M2 to null : #2118
b. Unlike L1/L2, for M1/M2:
Refer to the paragraph 362 ~ 363 in DSP0274_1.2.1.pdf.

If a response contains an ErrorCode other than ResponseNotReady :
No concatenation function is performed on the contents of both the original request and response.

[steven-bellock]

Busy should not affect the transcript as well, but that's an issue with the specification. I will file an issue against the specification.

[steven-bellock]

After talking with the SPDM Working Group, Busy is still being discussed, but LargeResponse should definitely not reset L1/L2.

[jyao1]

I dropped BUSY in this PR.

If SPDM decides to add BUSY later, we can add a new issue.