Need test: Completion of CHALLENGE sets M1/M2 to null .

[Zhiqiang520]

Completion of CHALLENGE sets M1/M2 to null .

1. Refer to the paragraph 382 Table 38 — Request ordering and message transcript computation rules for M1/M2 in DSP0274_1.2.1.pdf.
   
2. So I think maybe the following two libspdm_reset_message_* functions should be called before status = LIBSPDM_STATUS_SUCCESS; at the line 339.

libspdm_reset_message_b(spdm_context);
libspdm_reset_message_c(spdm_context);

libspdm/library/spdm_requester_lib/libspdm_req_challenge.c

Lines 338 to 343 in 83cbb2f

	spdm_context->connection_info.connection_state = LIBSPDM_CONNECTION_STATE_AUTHENTICATED;
	status = LIBSPDM_STATUS_SUCCESS;
	receive_done:
	libspdm_release_receiver_buffer (spdm_context);
	return status;

3. So I think maybe the following two libspdm_reset_message_mut_* functions should be called before return LIBSPDM_STATUS_SUCCESS; at the line 188.

libspdm_reset_message_mut_b(spdm_context);
libspdm_reset_message_mut_c(spdm_context);

libspdm/library/spdm_requester_lib/libspdm_req_encap_challenge_auth.c

Lines 186 to 188 in 83cbb2f

	ptr += signature_size;
	return LIBSPDM_STATUS_SUCCESS;

4. So I think maybe the following two libspdm_reset_message_mut_* functions should be called before return LIBSPDM_STATUS_SUCCESS; at the line 222.

libspdm_reset_message_mut_b(spdm_context);
libspdm_reset_message_mut_c(spdm_context);

libspdm/library/spdm_responder_lib/libspdm_rsp_encap_challenge.c

Lines 217 to 222 in 83cbb2f

	libspdm_set_connection_state(spdm_context,
	LIBSPDM_CONNECTION_STATE_AUTHENTICATED);
	*need_continue = false;
	return LIBSPDM_STATUS_SUCCESS;

[steven-bellock]

@jyao1 to follow up. This might be reset in something like spdm_reset_message_buffer_via_request_code, and should have been implemented in #93.

[jyao1]

@Zhiqiang520 , I checked the code and found that they are reset at

• https://github.com/DMTF/libspdm/blob/main/library/spdm_common_lib/libspdm_com_crypto_service.c#L810-L814
• https://github.com/DMTF/libspdm/blob/main/library/spdm_common_lib/libspdm_com_crypto_service.c#L1023-L1028

Would you please double check?

[Zhiqiang520]

@jyao1, Sorry for my misleading, Completion of CHALLENGE sets M1/M2 to null is already implemented in the current code you found.
I have tested in my forked repository, test result is pass: Zhiqiang520#10.
You can remove bug label and close this fake issue.

[jyao1]

can you add such test to libspdm?

I would like to change it as test issue and assign to you.

[Zhiqiang520]

I have submitted the PR to add the test cases to libspdm.