Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit tests #2823

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor unit tests #2823

wants to merge 3 commits into from

Conversation

steven-bellock
Copy link
Contributor

  1. Move the test context inside the _main function, as it is not needed outside the function.
  2. Make functions static where appropriate.

Signed-off-by: Steven Bellock sbellock@nvidia.com

@steven-bellock steven-bellock added test For tests and testing infrastructure refactor Should not affect functionality labels Sep 2, 2024
@steven-bellock
Copy link
Contributor Author

For the tests to pass #2822 needs to go in first.

@steven-bellock
Move Requester unit test context inside _main
6260279 
Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock
Move Responder unit test context inside _main
447d2ed 
Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock
Make callback functions static
0346ae0 
Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock steven-bellock marked this pull request as ready for review September 3, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 Awaiting requested review from jyao1

Assignees
No one assigned
Labels
refactor Should not affect functionality test For tests and testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@steven-bellock