Add EventAllPolicy to key exchange #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-bellock
force-pushed
the
event-all-policy
branch
2 times, most recently
from
f72e3a6
to
aa1a634
Compare
jyao1
reviewed
Sep 18, 2024
jyao1
reviewed
Sep 18, 2024
Comment on lines
308
to
312
| LIBSPDM_ASSERT(((session_policy & SPDM_KEY_EXCHANGE_REQUEST_SESSION_POLICY_EVENT_ALL_POLICY) | ||
| == 0) || | ||
| libspdm_is_capabilities_flag_supported( | ||
| spdm_context, true, 0, SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_EVENT_CAP)); |
There was a problem hiding this comment.
This check should only for SPDM 1.3 where the event is introduced.
Otherwise, the reserved bit should be ignored.
Fix DMTF#2566 Signed-off-by: Steven Bellock <sbellock@nvidia.com>
steven-bellock
force-pushed
the
event-all-policy
branch
from
aa1a634
to
d52d739
Compare
jyao1
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2566.
This pull request adds two parameters to
libspdm_event_subscribe.session_idis needed because event subscription is based on sessions, andsubscribe_typespecifies whether to subscribe/unsubscribe to all events, or to use the event list. Previouslysubscribe_event_group_count == 0was used to unsubscribe from all events. However that does not work for subscribing to all events. Ie,subscribe_event_group_count == 0xffis legal with the event list.Signed-off-by: Steven Bellock sbellock@nvidia.com