Remove mbedtls alt definition for platform_zeroize #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix CI failure. |
|
maybe put MBEDTLS_PLATFORM_ZEROIZE_ALT around mbedtls_platform_zeroize ? |
rjoleary
force-pushed
the
feature/zeroize
branch
3 times, most recently
from
4697042 to
b8e8be6
Compare
In the event you are compiling with a custom mbedtls config which does not define MBEDTLS_PLATFORM_ZEROIZE_ALT, there will be two definitions of mbedtls_platform_zeroize and a linker error. Signed-off-by: Ryan O'Leary <roleary@nvidia.com>
rjoleary
force-pushed
the
feature/zeroize
branch
from
b8e8be6 to
b1b1ac1
Compare
Thank you! I addressed the build failures with your suggested fix. |
jyao1
approved these changes
Jul 16, 2025
rjoleary
changed the title
|
@rjoleary In your build system you are commenting out correct? |
No, I do not use this file at all. In our project, multiple libraries depend on mbedtls which results in a diamond problem. I extracted all the common mbedtls settings into a common config file which is used across multiple libraries in our project. |
steven-bellock
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mbedtls has a function by the same name which creates a linker error.
Fixes #3070