Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library/pci_doe_responder_lib: Use libspdm DOE encode/decode helpers #268

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

alistair23
Copy link
Contributor

Instead of encoding and decoding DOE discovery packets manually inside spdm-emu let's instead use the generic helper functions in libspdm. This way we can test functions that others can also utilise to when using libspdm.

Instead of encoding and decoding DOE discovery packets manually inside
spdm-emu let's instead use the generic helper functions in libspdm. This
way we can test functions that others can also utilise to when using
libspdm.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23
Copy link
Contributor Author

This depends on DMTF/libspdm#2012 being merged and then the version of libspdm to be updated to include the change from DMTF/libspdm#2012. It won't build until then

@jyao1
Copy link
Member

jyao1 commented Dec 18, 2023

This depends on DMTF/libspdm#2012 being merged and then the version of libspdm to be updated to include the change from DMTF/libspdm#2012. It won't build until then

That is fine. Question: if you think this patch is ready for review?

@alistair23
Copy link
Contributor Author

alistair23 commented Dec 18, 2023

This is ready to go, it just needs DMTF/libspdm#2012 merged first. Hence the draft status as it would break the build if merged without DMTF/libspdm#2012

Also libspdm in this repo would need to be updated once DMTF/libspdm#2012 is merged

@jyao1
Copy link
Member

jyao1 commented Dec 19, 2023

This is ready to go, it just needs DMTF/libspdm#2012 merged first.

OK. if so, please change to ready for review. I will sync libspdm, then merge this.

Draft means you are still working on it, IMHO.

Hence the draft status as it would break the build if merged without DMTF/libspdm#2012

I will not merge anything if CI fails.

@alistair23 alistair23 marked this pull request as ready for review December 19, 2023 00:49
@jyao1 jyao1 closed this Dec 21, 2023
@jyao1 jyao1 reopened this Dec 21, 2023
@jyao1 jyao1 merged commit aa72b04 into DMTF:main Dec 21, 2023
26 checks passed
@alistair23 alistair23 deleted the alistair/doe-helper branch December 21, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants