Check "Implicit TE State Change" in cxl_tsp_validate_capability #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
approved these changes
Nov 20, 2024
According to CXL Spec 3.1 Table 11-32 Get Target Capabilities Response (Sheet 2 of 3) Byte Offset (0Ch): Bit[2]: Implicit TE State Change: When set, indicates that the target supports implicit TE State changes using a 64B granularity, Explicit In-band TE State Change shall be set, and Explicit In-band TE State Granularity support for 64B shall be set. This bit shall be checked in cxl_tsp_validate_capability. Signed-off-by: Min M Xu <min.m.xu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #395
According to CXL Spec 3.1 Table 11-32 Get Target Capabilities Response (Sheet 2 of 3) Byte Offset (0Ch):
Bit[2]: Implicit TE State Change: When set, indicates that the target
supports implicit TE State changes using a 64B granularity, Explicit
In-band TE State Change shall be set, and Explicit In-band TE State
Granularity support for 64B shall be set.
This bit shall be checked in cxl_tsp_validate_capability.