This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Removes duplicate dll packaging #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
Sep 25, 2019
|
Administrative approving this as this is a build/release support activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a CopyBin target and the Dnn ExtensionPackager already picked up the module dll. So the Dll was listed twice as a relative and an absolute path. This is why the dll was present twice in the zip although it would have been impossible in the filesystem.
For a quick fix and to not break anything else, I just removed the CopyBin call thus avoiding this duplication and allowing for a quick 9.4.1 release that installs.
A better solution might be to improve the whole build script, but we could do this later.
Closes #125 and dnnsoftware/Dnn.Platform#2962