Issue 231

[KevinSigl]

Description of PR...

Fix to Module settings not saving

Changes made

• string.join in EventModuleSettings.cs changed to Array as an ArrayList is not recognized as a collection but as one object
• foreach in EditEvents and SelectCategory sometimes get passed a string "-1" so cast to int was switched to a convert
• UpdateSettings was switched from using a temporary settings object to EventBase.Settings or it wouldn't be updated

PR Template Checklist

• Fixes Bug
• Feature solution
• Other

Please mark which issue is solved

Close #231

[valadas]

That looks about right to me

[HZass]

Implementing the changes to the code, I find that the module does not process the Location code in the same manner as the upgraded Category code. This manifests itself in the Edit function. If you change the category to a single entry, it is handles correctly in that it is the only one presented for addition/modification of events. However, if you set the Location code to a single entry, the selection drop down box still shows "All" instead of the single location selected in the Edit Settings panel.

[stale]

We have detected this issue has not had any activity during the last 180 days.
That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue.
We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 21 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future.
Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all.
Thank you for your continued involvement and contributions!