Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP session handling #88

Closed
jelu opened this issue Aug 25, 2017 · 0 comments
Closed

TCP session handling #88

jelu opened this issue Aug 25, 2017 · 0 comments

Comments

@jelu
Copy link
Member

jelu commented Aug 25, 2017

The current TCP session code must see the beginning of the session to be able to follow it and may not be able to parse DNS that is fragmented across multiple packets.

This deliverable will take an ongoing TCP session and try to parse it as DNS, overhaul the current TCP session code w.r.t. fragmented IP packets, create tests and test data that runs the reassembly code for both correct and incorrect TCP sessions.
@jelu jelu mentioned this issue Dec 20, 2017
Open
jelu added a commit to jelu/dnscap that referenced this issue Jan 11, 2018
@jelu
Fix DNS-OARC#88: TCP handling
3c90415 
- Move TCP state code to own files
- Parse additional DNS queries in TCP connections
- New extended options:
  - `parse_ongoing_tcp`: Start tracking TCP connections even if SYN/ACK
    has not been seen
  - `allow_reset_tcpstate`: Allow external reset of TCP state
- New extension functions for plugins:
  - `DNSCAP_EXT_TCPSTATE_GETCURR`: Function to get a pointer for the
    current TCP state
  - `DNSCAP_EXT_TCPSTATE_RESET`: Function to reset a TCP state
- `-g` and the `txtout` plugin will reset TCP state (if allowed) on
  failure to parse DNS
- Fix TCP packets wrongfully flagged as DNS when using layers.
- Fix TCP debug output when using layers, `ia_str()` is not safe to call
  twice in the same `printf` because of local buffer.
- Add test for:
  - Multiple DNS queries in one TCP connection
  - Query over TCP without SYN
  - Queries over TCP with first query missing length
jelu added a commit to jelu/dnscap that referenced this issue Jan 11, 2018
@jelu
Fix DNS-OARC#88: TCP handling
53bd00a 
- Move TCP state code to own files
- Parse additional DNS queries in TCP connections
- New extended options:
  - `parse_ongoing_tcp`: Start tracking TCP connections even if SYN/ACK
    has not been seen
  - `allow_reset_tcpstate`: Allow external reset of TCP state
- New extension functions for plugins:
  - `DNSCAP_EXT_TCPSTATE_GETCURR`: Function to get a pointer for the
    current TCP state
  - `DNSCAP_EXT_TCPSTATE_RESET`: Function to reset a TCP state
- `-g` and the `txtout` plugin will reset TCP state (if allowed) on
  failure to parse DNS
- Fix TCP packets wrongfully flagged as DNS when using layers.
- Fix TCP debug output when using layers, `ia_str()` is not safe to call
  twice in the same `printf` because of local buffer.
- Add test for:
  - Multiple DNS queries in one TCP connection
  - Query over TCP without SYN
  - Queries over TCP with first query missing length
- Update copyright
jelu added a commit to jelu/dnscap that referenced this issue Jan 11, 2018
@jelu
Fix DNS-OARC#88: TCP handling
123b29e 
- Move TCP state code to own files
- Parse additional DNS queries in TCP connections
- New extended options:
  - `parse_ongoing_tcp`: Start tracking TCP connections even if SYN/ACK
    has not been seen
  - `allow_reset_tcpstate`: Allow external reset of TCP state
- New extension functions for plugins:
  - `DNSCAP_EXT_TCPSTATE_GETCURR`: Function to get a pointer for the
    current TCP state
  - `DNSCAP_EXT_TCPSTATE_RESET`: Function to reset a TCP state
- `-g` and the `txtout` plugin will reset TCP state (if allowed) on
  failure to parse DNS
- Fix TCP packets wrongfully flagged as DNS when using layers.
- Fix TCP debug output when using layers, `ia_str()` is not safe to call
  twice in the same `printf` because of local buffer.
- Add test for:
  - Multiple DNS queries in one TCP connection
  - Query over TCP without SYN
  - Queries over TCP with first query missing length
- Update copyright
jelu added a commit to jelu/dnscap that referenced this issue Jan 11, 2018
@jelu
Fix DNS-OARC#88: TCP handling
95291a0 
- Move TCP state code to own files
- Parse additional DNS queries in TCP connections
- New extended options:
  - `parse_ongoing_tcp`: Start tracking TCP connections even if SYN/ACK
    has not been seen
  - `allow_reset_tcpstate`: Allow external reset of TCP state
- New extension functions for plugins:
  - `DNSCAP_EXT_TCPSTATE_GETCURR`: Function to get a pointer for the
    current TCP state
  - `DNSCAP_EXT_TCPSTATE_RESET`: Function to reset a TCP state
- `-g` and the `txtout` plugin will reset TCP state (if allowed) on
  failure to parse DNS
- Fix TCP packets wrongfully flagged as DNS when using layers.
- Fix TCP debug output when using layers, `ia_str()` is not safe to call
  twice in the same `printf` because of local buffer.
- Add test for:
  - Multiple DNS queries in one TCP connection
  - Query over TCP without SYN
  - Queries over TCP with first query missing length
- Update copyright
- Fix extension for OpenBSD, functions need to be file local
jelu added a commit to jelu/dnscap that referenced this issue Jan 11, 2018
@jelu
Fix DNS-OARC#88: TCP handling
14d53da 
- Move TCP state code to own files
- Parse additional DNS queries in TCP connections
- New extended options:
  - `parse_ongoing_tcp`: Start tracking TCP connections even if SYN/ACK
    has not been seen
  - `allow_reset_tcpstate`: Allow external reset of TCP state
- New extension functions for plugins:
  - `DNSCAP_EXT_TCPSTATE_GETCURR`: Function to get a pointer for the
    current TCP state
  - `DNSCAP_EXT_TCPSTATE_RESET`: Function to reset a TCP state
- `-g` and the `txtout` plugin will reset TCP state (if allowed) on
  failure to parse DNS
- Fix `-g` output, separate error message with a space
- Fix TCP packets wrongfully flagged as DNS when using layers.
- Fix TCP debug output when using layers, `ia_str()` is not safe to call
  twice in the same `printf` because of local buffer.
- Add test for:
  - Multiple DNS queries in one TCP connection
  - Query over TCP without SYN
  - Queries over TCP with first query missing length
- Update copyright
- Fix extension for OpenBSD, functions need to be file local
@jelu jelu closed this as completed in a57066f Jan 11, 2018
jelu added a commit that referenced this issue Jan 11, 2018
@jelu
Merge pull request #132 from jelu/tcp
26cab54 
Fix #88: TCP handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelu