EDNS0 parsing fixes and additional EDNS0 indexers. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdrenard I will need you to describe what you fixed here, preferable also if you can split the fix to EDNS parsing and the new indexers, and would be good with test cases. |
jelu
added a commit
to kdrenard/dsc
that referenced
this pull request
Jul 5, 2023
- Refactor pull request DNS-OARC#288 - Implement additional indexers for EDNS(0) cookie, ECS, EDE and NSID - Add indicators for indexers to use to control is EDNS, and options, are parsed
jelu
force-pushed
the
kdrenard_ends0_updates
branch
from
2c17b27 to
3a08de2
Compare
- Refactor pull request DNS-OARC#288 - Implement additional indexers for EDNS(0) cookie, ECS, EDE and NSID - Add indicators for indexers to use to control is EDNS, and options, are parsed - `hashtbl`: add `strtohex()`, convert fixed length string to hexadecimals
jelu
force-pushed
the
kdrenard_ends0_updates
branch
from
3a08de2 to
b5164fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.