Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hel 537/page admin #410

Closed
wants to merge 69 commits into from
Closed

Hel 537/page admin #410

wants to merge 69 commits into from

Conversation

schlaifa
Copy link
Contributor

@schlaifa schlaifa commented Jan 4, 2024

Vérifier avant de merger

  • As-tu correctement relu ton code ?
  • As-tu besoin de revoir ton ticket avec la PO ou UX ?
  • Faut-il rajouter une nouvelle date de mise à jour sur la production ?
  • Faut-il rajouter des données dans data_set ?
  • Faut-il ajouter des variables d'environnement sur la production ?
  • Faut-il mettre à jour middleware.ts et lighthouserc.js dû à la création/suppression d'une page ?
  • Faut-il modifier Content-Security-Policy dans next.config.js ?

Comment on lines +20 to +24
const resp = await fetch(`${basePath}/api/auth/session`, {
headers: headers,

method: "GET",
});

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

The
URL
of this request depends on a
user-provided value
.
className="fr-btn"
onClick={(event) => {
event.preventDefault();
router.push(paths.ACCUEIL + "?terme=" + terme, paths.ACCUEIL);

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
}
if (user) {
const hashing = createHash("sha256");
hashing.update(password);

Check failure

Code scanning / CodeQL

Use of password hash with insufficient computational effort High

Password from
an access to password
is hashed insecurely.
Password from
an access to password
is hashed insecurely.
Password from
an access to password
is hashed insecurely.
Password from
an access to password
is hashed insecurely.
Password from
an access to password
is hashed insecurely.
@schlaifa schlaifa closed this Jan 4, 2024
@schlaifa schlaifa deleted the hel-537/page-admin branch February 16, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants