fixed issue with cert resources not able to define encryption on read… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only, added variable support for transport_protocol, session_timeout_hours, and login_banner_text; updated output with dns name and updated documentation to reflect the changes
adenot
approved these changes
Sep 13, 2022
|
Hi @si-foley thanks for the PR. Do you mind fixing the merge conflict and I can merge it? |
|
I'd appreciate this fix too @adenot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big picture
Types of changes
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
transport_protocol,session_timeout_hours, andlogin_banner_text