Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/iam tags #37

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Feature/iam tags #37

merged 10 commits into from
Oct 3, 2023

Conversation

jeremiasroma
Copy link
Contributor

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jeremiasroma jeremiasroma added documentation Improvements or additions to documentation enhancement New feature or request feature-request New feature labels Oct 3, 2023
@jeremiasroma jeremiasroma linked an issue Oct 3, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@brunodasilvalenga brunodasilvalenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunodasilvalenga brunodasilvalenga merged commit 266ca73 into master Oct 3, 2023
@brunodasilvalenga brunodasilvalenga deleted the feature/iam-tags branch October 3, 2023 05:51
Copy link

github-actions bot commented Nov 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature-request New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS tags for IAM resources
2 participants