Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX proposal for a crash that happens because of some misuse of const_cast<> #1920

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Sep 8, 2022

  1. FIX proposal for a crash that happens when feeding ACE::sendv_n_i and

    ACE::writev_n with iovecs that have been allocated on the heap.
    In case of a partial send, libACE will loop until all the data has been
    sent. The problem is that it updates its arguments when doing so,
    leaving the caller with one or more updated pointers inside the table of
    iovecs. Attempting to free such a pointer results in a fault (the value
    can even not be aligned properly).
    The fix simply copies the iovec data _if necessary_ (no perf penalty
    otherwise), and updates those values instead of the arguments.
    Nibelheims committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    f196006 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Configuration menu
    Copy the full SHA
    738003b View commit details
    Browse the repository at this point in the history