-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++17 is the minimum required C++ level to compile ACE/TAO after this PR #2224
Conversation
… default C++ version for Visual Studio to 2017 * ACE/ace/Global_Macros.h: * ACE/bin/MakeProjectCreator/config/acedefaults.mpb: * ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb: * TAO/tests/Oneway_Send_Timeouts/Server_Task.h: * TAO/tests/Oneway_Send_Timeouts/main.cpp:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb: * ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb:
* ACE/include/makeinclude/platform_linux_clang.GNU: * ACE/include/makeinclude/platform_macosx_common.GNU:
* .github/workflows/linux.yml: * ACE/include/makeinclude/platform_linux_clang.GNU: * ACE/include/makeinclude/platform_macosx_common.GNU:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb: * ACE/bin/MakeProjectCreator/config/vs2017nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2019nmake.mpb: * ACE/bin/MakeProjectCreator/config/vs2022nmake.mpb:
* .github/workflows/cmake.yml:
* ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* .github/workflows/linux.yml:
* .github/workflows/linux.yml:
* ACE/include/makeinclude/platform_linux_clang.GNU:
* ACE/NEWS: * ACE/ace/checked_iterator.h:
ACE/NEWS
Outdated
@@ -1,6 +1,10 @@ | |||
USER VISIBLE CHANGES BETWEEN ACE-7.1.4 and ACE-7.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a major release if you're requiring a newer C++ standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make it a new minor, we are not deprecating specific compilers, just lifting the required C++ standard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop resolving this. I still don't agree.
Co-authored-by: Fred Hornsey <fred@hornsey.us>
* ACE/include/makeinclude/platform_gcc_clang_common.GNU:
* ACE/NEWS: * TAO/NEWS:
* ACE/NEWS:
…iler flags to suppress the stdext::checked_array_iterator deprecation warnings at this moment * ACE/bin/MakeProjectCreator/config/vc_warnings.mpb:
Jobs are failing because of some github issue actions/runner-images#9733 |
* .github/workflows/cmake.yml: * .github/workflows/linux.yml:
Fix #444, see DOCGroup/ACE_TAO#2224 for the upstream change.
Includes changes to set the C++ compiler default for Visual Studio 2017/2019/2022 to C++17