Fix detection of MacOSX SDKs older than 10.10 #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building ACE 8.0.0 on Mac OS X 10.6 fails:
because you are using the wrong
__MAC_OS_X_VERSION_MAX_ALLOWEDvalues for SDK versions earlier than 10.10. This PR fixes it. It also clarifies the error message:__MAC_OS_X_VERSION_MAX_ALLOWEDrepresents the version of the SDK, not the version of macOS currently being used on the build machine nor the minimum version of macOS that will be required to run the compiled program. (The latter would be the deployment target.)