fix for #2286 - avoid header compilation failure in %install phase #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phase by adding -std=c++17
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding -std=c++17 to avoid header compilation failure which removes them from the list of headers.
Fixing #2286 - tested on openSUSE15.6 with gcc 7.5 compiler which is not c++17 or newer by default.
The explanation for working with g++ 14.2 (on openSUSE Tumbleweed) is that the compiler is by default c++17 while g++ 7.5 is c++14 even if the compiler is capable of handling c++17 specs - which is actually used in compilation.