Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Add data test for jobs data #2323

Closed
gemfarmer opened this issue Jul 5, 2017 · 2 comments
Closed

Add data test for jobs data #2323

gemfarmer opened this issue Jul 5, 2017 · 2 comments
Labels
data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too p3: Medium This doesn’t prevent the site from being used and can wait a bit before fixing.

Comments

@gemfarmer
Copy link
Contributor

When we added the jobs by commodity issue (#2156), the source data changed so drastically that we had to scrap the old tests. Because we needed to get the data out the door and it appeared accurate, we didn't add tests at the time.

Expected Behavior

Data should be added and should compare source data to outputted yaml files.

  • self employment data is tested.
  • wage and salary jobs data is tested.
  • wage and salary jobs data by commodity data is tested.

Actual Behavior

None of the data is tested
@gemfarmer gemfarmer self-assigned this Jul 5, 2017
This was referenced Jul 5, 2017
Merged
Merged
@gemfarmer gemfarmer added this to the Sprint-PensivePine milestone Jul 14, 2017
@coreycaitlin coreycaitlin modified the milestone: Sprint-PensivePine Aug 15, 2017
@gemfarmer
Copy link
Contributor Author

@toolness this is a can of worms and definitely an important one to check out. We have pretty poor test coverage on this project, so figuring out better ways to test the code that we have and/or re-architecting to allow for easier testing are priorities!

@gemfarmer gemfarmer assigned toolness and unassigned gemfarmer Aug 28, 2017
@coreycaitlin coreycaitlin assigned msecret and unassigned toolness Oct 11, 2017
@coreycaitlin coreycaitlin added this to the Sprint-InquisitiveImpala milestone Oct 11, 2017
@coreycaitlin coreycaitlin removed this from the Sprint-SmoothSealion milestone Nov 28, 2017
@coreycaitlin coreycaitlin mentioned this issue Jan 17, 2018
Closed
5 tasks
@master12 master12 added the data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too label Mar 26, 2018
@jennmalcolm jennmalcolm added the p3: Medium This doesn’t prevent the site from being used and can wait a bit before fixing. label May 3, 2018
@jennmalcolm
Copy link
Contributor

Through content strategy decisions #2799, we have decided not to maintain job data in the future. So, I'm closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too p3: Medium This doesn’t prevent the site from being used and can wait a bit before fixing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@toolness @alexpandel @coreycaitlin @msecret @gemfarmer @master12 @jennmalcolm