Retry up to 3 times

DOI-USGS · Oct 20, 2024 · 3a3773f · 3a3773f
1 parent ac61269
commit 3a3773f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/R/getWebServiceData.R b/R/getWebServiceData.R
@@ -43,7 +43,7 @@ getWebServiceData <- function(obs_url, ...) {
       trys <- 1
       if (all(grepl("ERROR: INCOMPLETE DATA", returnedDoc))) {
 
-        while(trys <= 5){
+        while(trys <= 3){
           message("Trying again!")
           obs_url <- paste0(obs_url, "&try=", trys)
           returnedList <- retryGetOrPost(obs_url)

diff --git a/tests/testthat/tests_general.R b/tests/testthat/tests_general.R
@@ -502,6 +502,8 @@ test_that("internal functions", {
 })
 
 test_that("profiles", {
+
+  testthat::skip_on_cran()
   # Data profiles: "Organization Data"
   org_data <- readWQPdata(
     statecode = "WI",

diff --git a/tests/testthat/tests_userFriendly_fxns.R b/tests/testthat/tests_userFriendly_fxns.R
@@ -150,6 +150,8 @@ test_that("WQP qw tests", {
   df <- readWQPqw("USGS-04193500", parameterCd = "00665")
   expect_true(nrow(df) > 0)
 
+  df2 <- readWQPqw("USGS-05427718", parameterCd = "all")
+  expect_true(nrow(df2) > 0)
 })
 
 context("readNWISstat tests")