[#116] initial implementation of type hints #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thodson-usgs
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Excellent @pkdash!
I noticed the 3.8 tests were failing. I suspect tuple is only supported for 3.9+.
Please make this change and all tests should pass.
Co-authored-by: Timothy Hodson <34148978+thodson-usgs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of adding type hints that includes type hints just for one function of
nwismodule. If this looks good, I can implement the same for the rest of the functions of thenwismodule.