129 data downloading issue with a specific gauging station #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thodson-usgs
force-pushed
the
129-data-downloading-issue-with-a-specific-gauging-station
branch
from
d5b19a8
to
20a623c
Compare
thodson-usgs
deleted the
129-data-downloading-issue-with-a-specific-gauging-station
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites use a method code of 'x', which was breaking the json parser, which interpret '_x' as a duplicate column following pandas
mergeconvention.This fix removes
update_merge()entirely (I might regret this 💣 💥) and adds the functionality into the json parser itself. If nothing else, this should improve performance.