-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning message for qw data queries #134
Conversation
@thodson-usgs works for me. Changed. |
After chatting with @lstanish-usgs and @ldecicco-USGS, I think I have a few other messages to edit/add. This is still in draft. I will indicate when it's ready. |
@thodson-usgs, inspired by the approach taken by @ldecicco-USGS in R |
@ehinman thanks for the text update! Just one more date update for the nwis.py function, otherwise this looks good from my end. @thodson-usgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Can you provide your input, @thodson-usgs? #134 (comment) |
It's really the job of the service to provide these sorts of warnings, not the wrapping library (we merely convey them). |
Sounds good @thodson-usgs. I am going to create a separate PR for it, so we can at least have some messaging out there right now. |
This MR is ready to merge on my end. @thodson-usgs @lstanish-usgs. |
@thodson-usgs this looks approved from my end, is it OK to go ahead and merge? Thanks |
This MR adds warnings to
nwis.get_qwdata
andnwis.get_info
whenseriesCatalogOutput=True
about the impending lack of updates to the qw service. Please review for accuracy in content and that the location and warning specifications are sufficient within the functions. Thanks!