Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial prep #140

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Tutorial prep #140

merged 2 commits into from
Jun 4, 2024

Conversation

thodson-usgs
Copy link
Collaborator

Add FIPS state codes and links to WQP swagger doc.

@thodson-usgs thodson-usgs requested a review from ehinman June 4, 2024 15:14
@thodson-usgs
Copy link
Collaborator Author

@ehinman, just some minor changes to prepare for the waterscicon tutorial

@ehinman
Copy link
Collaborator

ehinman commented Jun 4, 2024

Looks good to me. How would someone know to go to the states.py file to reference the FIPs codes/abbreviations?

@thodson-usgs
Copy link
Collaborator Author

Looks good to me. How would someone know to go to the states.py file to reference the FIPs codes/abbreviations?

It's probably not well documented, so you'd have to be a source reader.

Normally, these sorts of lookups would be done behind the scenes, but the WQP interface is bare bones. This dict is mainly to provide a convenience for some common use patterns, but isn't really a function provided by the dataretrieval package

@thodson-usgs thodson-usgs merged commit 3ae36b3 into DOI-USGS:master Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants