Remove hardcoded format in nwis.get_discharge_measurements #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehinman
reviewed
Aug 7, 2024
ehinman
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
The changes look good to me. I'd really like to pull down your changes and do a quick test on my own machine, but I can't figure out how to do that. Due to the urgency, I'm fine with approving, but if you can tell me how to easily do this for next time, that would be ideal. I tried to clone your fork, but my computer didn't like that I already had the upstream repo in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR allows users to pass format to
nwis.get_discharge_measurementswhile retaining backwards compatibility.