Feature/cash bleeders #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacio
approved these changes
Jun 17, 2024
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install --upgrade --upgrade-strategy eager -r .github/workflows/utils_requirements.txt |
There was a problem hiding this comment.
Why always upgrade pytest instead of fixing its version?
| pip install --upgrade --upgrade-strategy eager -r .github/workflows/utils_requirements.txt | ||
| - name: Run tests | ||
| run: | | ||
| pytest --junitxml=report.xml |
There was a problem hiding this comment.
Is the report retrievable later?
There was a problem hiding this comment.
Just for the record... Why all the changes in the requirements?
There was a problem hiding this comment.
It turned out that these bibs were unnecessary
| if not isinstance(name, str) or not isinstance(data_type, str): | ||
| raise ValueError("Each tuple must contain a column name and data type as strings.") | ||
| if data_type.upper() not in valid_types: | ||
| raise ValueError(f"Invalid data type '{data_type}'. Supported types are: {', '.join(sorted(valid_types))}") |
There was a problem hiding this comment.
inform which column had the invalid data_type
There was a problem hiding this comment.
Good one, This should go for a improvements section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Utils methods;
Adding Pytest for Utils methods;
Testing Pytest workflow with github actions behavior for Pull Requests;