Skip to content

In the contestant's clarifications block, the shortname and color of the problem are not displayed correctly. #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dup4 opened this issue Dec 13, 2023 · 8 comments · Fixed by #2576 or #2607

Comments

@Dup4
Copy link
Contributor

Dup4 commented Dec 13, 2023

NOTE: If this is a discussion starter, you need any installation help or have a question on how to accomplish something,
rather post at our discussion channel or send an email to our
DOMjudge-devel mailinglist
instead of filing an issue here.

Description of the problem

image

This is the problem I set in the contest, with the correct shortname and color set.

image

This is the Clarifications page in the administrator interface, showing the correct shortname and color.

image

But this is the Clarifications page in the contestant's interface, and it doesn't show the correct shortname and color.

This should be the shortname of the problem.

Your environment

  • DOMjudge: 8.2.2
  • OS: Ubuntu22.04
  • webserver: nginx

Steps to reproduce

  • create a contest.
  • send a clarification in contestant's interface.

Expected behaviour

Replace this line with what you would expect to happen.

On the Clarifications page in the contestant's interface, the correct shortname and color are shown.

Actual behaviour

Replace this line with what happens instead.

The Clarifications page in the contestant's interface currently shows the externalid of the title and the color black.

Any other information that you want to share?

image

My data source options are set like this.

@Dup4 Dup4 changed the title In the player's Clarifications block, the shortname and color of the problem are not displayed correctly. In the contestant's Clarifications block, the shortname and color of the problem are not displayed correctly. Dec 13, 2023
@nickygerritsen
Copy link
Member

I tried reproducing this on 8.2.2, but I can't, even with that data source option. A dump of relevant tables of your database might help.

@Dup4
Copy link
Contributor Author

Dup4 commented Dec 14, 2023

Maybe it's because I have two contests?

image

TESTOFFICIAL:

image

Hangzhou_Onsite:

image

I didn't set the correct shortname in the first contest(TESTOFFICIAL).

But our official contest is in the second contest(Hangzhou_Onsite).

@vmcj
Copy link
Member

vmcj commented Dec 14, 2023

Maybe it's because I have two contests?
image

TESTOFFICIAL:
image

Hangzhou_Onsite:
image

I didn't set the correct shortname in the first contest(TESTOFFICIAL).

But our official contest is in the second contest(Hangzhou_Onsite).

You are aware that the color (and shortname) for a problem is set per contest? So it would really be helpful for us to get a dump so we can easily check what is set.

If I understand you correctly you have the datasource to 1, but expect in the contestant interface that the shortname is shown? We display the externalID by design for this mode as to any outsider (either contestant or a downstream client) we use the externalID, and only internally (for us as admin maybe jury or in the database) we might use the internal identifier.

Also the color in the TESTOFFICIAL is for all problems set to black, that is the same as what we see for the contestant when they are in that contest? Have you set specific colors for that problem already? Are the problems shared over multiple contests?

@Dup4 Dup4 changed the title In the contestant's Clarifications block, the shortname and color of the problem are not displayed correctly. In the contestant's clarifications block, the shortname and color of the problem are not displayed correctly. Dec 14, 2023
@Dup4
Copy link
Contributor Author

Dup4 commented Dec 14, 2023

I can provide you with a sql dump, but how do I transfer it to you?

@nickygerritsen
Copy link
Member

I can provide you with a sql dump, but how do I transfer it to you?

The best option is to send it in a PM in Slack I think.

@vmcj
Copy link
Member

vmcj commented May 21, 2024

@Dup4 did you send the dump to @nickygerritsen or can we close this issue?

@2018hahazhufeng
Copy link
Contributor

The same issue happened to me last week. I can also provide a dump in case it's needed.

@vmcj
Copy link
Member

vmcj commented May 23, 2024

The same issue happened to me last week. I can also provide a dump in case it's needed.

That would be helpful, you can send it to one of us on Slack (or share it via pastebin for example).

vmcj added a commit to vmcj/domjudge that referenced this issue May 27, 2024
If you test a problem in contest A with shortname "bla" and run your
real contest B (problem shortname "C") we would pick the first
contestProblem so we would have displayed "bla" for the clarification.

Fixes DOMjudge#2279
vmcj added a commit to vmcj/domjudge that referenced this issue May 27, 2024
If you test a problem in contest A with shortname "bla" and run your
real contest B (problem shortname "C") we would pick the first
contestProblem so we would have displayed "bla" for the clarification.

Fixes DOMjudge#2279

(cherry picked from commit f3725a1)
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
If you test a problem in contest A with shortname "bla" and run your
real contest B (problem shortname "C") we would pick the first
contestProblem so we would have displayed "bla" for the clarification.

Fixes #2279

(cherry picked from commit f3725a1)
vmcj added a commit that referenced this issue May 28, 2024
If you test a problem in contest A with shortname "bla" and run your
real contest B (problem shortname "C") we would pick the first
contestProblem so we would have displayed "bla" for the clarification.

Fixes #2279
moesoha added a commit to moesoha/domjudge that referenced this issue Jun 17, 2024
moesoha added a commit to moesoha/domjudge that referenced this issue Jun 17, 2024
moesoha added a commit to moesoha/domjudge that referenced this issue Jun 17, 2024
vmcj pushed a commit to vmcj/domjudge that referenced this issue Jul 20, 2024
vmcj pushed a commit to vmcj/domjudge that referenced this issue Jul 20, 2024
vmcj pushed a commit to vmcj/domjudge that referenced this issue Jul 20, 2024
vmcj pushed a commit that referenced this issue Jul 22, 2024
cubercsl pushed a commit to cubercsl/domjudge that referenced this issue Aug 3, 2024
cubercsl pushed a commit to cubercsl/domjudge that referenced this issue Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants