Change all clarifications in thread #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijskh
approved these changes
Nov 24, 2023
vmcj
force-pushed
the
clarification_message
branch
from
1897124 to
5652cb7
Compare
eldering
reviewed
Nov 24, 2023
| @@ -352,7 +352,13 @@ public function changeQueueAction(Request $request, int $clarId): Response | |||
| if ($queue === "") { | |||
| $queue = null; | |||
| } | |||
| $clarification->setQueue($queue); | |||
|
|
|||
| // Either this is the first in a thread (of 1 or more) or this 2nd or more. | |||
There was a problem hiding this comment.
This comment is not really clear to me: or this 2nd or more.
There was a problem hiding this comment.
Removed the comment as Nicky his fix made this easy enough to read in code.
…replies By always finding the first clarification and changing the replies afterwards. Verified that this also works via the overview clarification page. In the UI this looks like a thread but this is not true in the database. A team clarification will always be the first clarification, in case the jury sends a clarification and the team responds this will be a new clarification (but quoted with the earlier messages) Verified nows also that when a team sends a clarification and jury responds and team responds that this gives 3 clarifications where 2 are connected (team->jury)(->team). Co-authored-by: Nicky Gerritsen <nickygerritsen@me.com>
vmcj
force-pushed
the
clarification_message
branch
from
5652cb7 to
f81f88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By always finding the first in thread and changing the replies afterwards. Verified that this also works via the overview clarification page.
Partial fix for: #1785