Last gitlab ci #2825
Merged
Last gitlab ci #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
last_gitlab_ci
branch
4 times, most recently
from
a693cfa to
1890f89
Compare
vmcj
force-pushed
the
last_gitlab_ci
branch
17 times, most recently
from
562196c to
0b8379a
Compare
vmcj
force-pushed
the
last_gitlab_ci
branch
6 times, most recently
from
8e78c50 to
1ad3150
Compare
nickygerritsen
approved these changes
Dec 9, 2024
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| class RejudgingType extends AbstractType | |||
| { | |||
| public function __construct(protected readonly DOMJudgeService $dj, protected readonly EntityManagerInterface $em) | |||
| public function __construct(protected readonly ConfigurationService $config, protected readonly EntityManagerInterface $em) | |||
There was a problem hiding this comment.
This commit needs to be dropped but you are probably already aware.
The GitLab folder will be removed so this cleanup was needed. Also fixed displaying the sections for the GHA job output.
This is useful for when the tests suddenly break because the upstream images have changed.
We keep getting a warning about this so it's better to explicit test against that version.
Both useful for the integration & unit tests.
We'll need to play around with the unit test upload features (https://github.com/EnricoMi/publish-unit-test-result-action#configuration) what works best. This is based on what we do for the integration test. Most shared code is handled by baseinstall.sh. We can now also install a database with a different name as the unit tests use that locally. As side-effect we directly test this in CI. The CI ran on GitLab before and needed extra steps to push the result to GitHub. As everything is in GitHub Actions now we can remove those extra steps.
|
Also added the unit tests as required for merge queues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll squash the commits about the unit-tests after approval. Split them out to keep the flow understandable.