Clean up DOMJudgeService #2872
Merged
Clean up DOMJudgeService #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldering
force-pushed
the
cleanup-dj-service
branch
3 times, most recently
from
50f854b to
61f48c7
Compare
They don't depend on any DOMjudge internals.
eldering
force-pushed
the
cleanup-dj-service
branch
from
61f48c7 to
ba5462d
Compare
Also add some documentation.
meisterT
approved these changes
Dec 5, 2024
vmcj
reviewed
Dec 5, 2024
nickygerritsen
approved these changes
Dec 5, 2024
Co-authored-by: MCJ Vasseur <14887731+vmcj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a bunch of stuff that doesn't have to be here and that causes unnecessary dependencies.
And fix bug in getting verdicts as reported in slack.