Change default Python interpreter to pypy #914
Conversation
|
Hmmm, I think pypy3 does not exist in Debian stable yet? At least CI is complaining and that uses Debian currently. |
|
The CI uses bionic, not buster, so that must then be bumped to focal (not a bad thing per se) |
Yes Michael and me are trying to fix this |
pingiun
force-pushed
the
switch-to-pypy3
branch
from
594922f
to
50d9f2d
Compare
|
@pingiun in the gitlab.ci file you have to replace the gitlabci:1.0 for gitlab:2.0 also for the Docker in Docker jobs, But maybe you'll be in luck and my PR is fixed before so you can rebase against it. |
pingiun
force-pushed
the
switch-to-pypy3
branch
from
1d67955
to
94528ef
Compare
|
@pingiun Master/Main now has the gitlabci:2.0 for all tests, so it should be easier to get this one in a working state. Could you rebase and see if it works? |
pingiun
force-pushed
the
switch-to-pypy3
branch
from
94528ef
to
be669a6
Compare
|
Rebased |
|
This test is supposed to fail but now judged as “correct”: https://github.com/DOMjudge/domjudge/blob/master/tests/test-extra-file.py3.zip |
|
I have no clue why that might be, it seems to have no relation to my change |
|
Yes and no. Your changes expose a bug in the testsuite. So they are triggering the failure, but are not the cause. I propose you rebase on current master to see if your PR then passes. |
thijskh
force-pushed
the
switch-to-pypy3
branch
from
be669a6
to
c796a86
Compare
|
Merging, thanks for your contribution! |
This was kept in DOMjudge#914 but pypy3 has now proven itself so its not needed in the chroot anymore. Keeping it there might keep people on a 'slower' standard and make their competition harder than needed.
This was kept in #914 but pypy3 has now proven itself so its not needed in the chroot anymore. Keeping it there might keep people on a 'slower' standard and make their competition harder than needed.
We discussed in the slack that the default Python interpreter should be switched to pypy. I believe previously this wasn't done because pypy3 packages weren't readily available. They are now, and it seems many contests are using pypy3 already.
This PR adds pypy3 to the chroot (and leaves python3 in place for contests that want to supply their own runscript for it), and changes the python interpreter in the run script.