New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: check isinstance instead of type #260

Closed

Roel opened this issue Apr 18, 2020 · 0 comments · Fixed by #271

Assignees

Labels

good-first-issue tests

Milestone

Member

Roel commented Apr 18, 2020 •

edited

Loading

From the pyOpenSci review:

In the tests, you can change assert type(df) is DataFrame to assert isinstance(df, DataFrame)

This applies generally I think and needs to be checked and refactored everywhere in the tests (i.e. not only for the DataFrame case)

Roel added the tests label

Roel added this to the v2.0.0 milestone

Roel added the good-first-issue label

jorissynaeve self-assigned this

jorissynaeve linked a pull request

that will close this issue

Merged

Roel closed this as completed in #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment