Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 260 #271

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix 260 #271

merged 2 commits into from
May 28, 2020

Conversation

jorissynaeve
Copy link
Collaborator

  • [x ] I have read and followed the guidelines in the CONTRIBUTING document
  • [x ] I have checked to ensure there aren't other open Pull Requests for the same update/change
  • [x ] I have updated the documentation accordingly.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Describe your fixes/additions/changes

@jorissynaeve jorissynaeve requested a review from Roel May 28, 2020 12:03
@jorissynaeve jorissynaeve linked an issue May 28, 2020 that may be closed by this pull request
Tests: check isinstance instead of type #260
Closed
Roel
Roel approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@Roel Roel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Roel Roel added this to the v2.0.0 milestone May 28, 2020
@Roel Roel merged commit cb7923b into master May 28, 2020
@Roel Roel deleted the fix-260 branch May 28, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roel Roel Roel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Tests: check isinstance instead of type
2 participants
@jorissynaeve @Roel