Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make folium code examples compatible with latest pyproj version #275

Closed
stijnvanhoey opened this issue May 28, 2020 · 1 comment
Closed
Assignees
Labels
docs Documentation
Milestone

Comments

@stijnvanhoey
Copy link
Collaborator

Some of the current tutorial notebooks use a small support function to convert coordinates, making plotting with folium possible. Runnning them currently provides a lot of FutureWarning. As such, make sure to update the code of convert_latlon to make it compatible with newer pyproj versions:

from pyproj import Transformer

# convert the coordinates to lat/lon for folium
def convert_latlon(x1, y1):
    transformer = Transformer.from_crs("epsg:31370", "epsg:4326", always_xy=True)
    x2,y2 = transformer.transform(x1, y1)
    return x2, y2
@stijnvanhoey stijnvanhoey self-assigned this May 28, 2020
@stijnvanhoey
Copy link
Collaborator Author

Note: this is more future proof than adding import warnings; warnings.simplefilter('ignore') ;-)

@Roel Roel added this to the v2.0.0 milestone May 29, 2020
@Roel Roel added the docs Documentation label May 29, 2020
@Roel Roel closed this as completed in c083ec5 May 29, 2020
Roel added a commit that referenced this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

No branches or pull requests

2 participants