Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine PFAS data of the same matrix #392

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

GuillaumeVandekerckhove
Copy link
Contributor

@GuillaumeVandekerckhove GuillaumeVandekerckhove commented Aug 3, 2023

  • I have read and followed the guidelines in the CONTRIBUTING document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

To the PFAS contribution file I added the options to combine the data of the same matrix and save in an extra tab of the output Excel file.

@Roel
Copy link
Member

Roel commented Aug 10, 2023

Do we also need to add these options to the documentation?

@Roel Roel merged commit 23d97d1 into DOV-Vlaanderen:master Aug 29, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants