Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching order for newComms patch compatibility #1

Closed
Gordon-Dry opened this issue Aug 7, 2019 · 3 comments
Closed

Patching order for newComms patch compatibility #1

Gordon-Dry opened this issue Aug 7, 2019 · 3 comments

Comments

@Gordon-Dry
Copy link
Contributor

To have your patches be compatible with my newComms patches which also have to obey some MM logic I suggest that you change at least the following:

GameData/RealAntennas/RealAntennas.cfg
line 168
AFTER[RealismOverhaul] -> AFTER[zzzRealismOverhaul]

@Gordon-Dry
Copy link
Contributor Author

Oh, there is a typo in your config, too...
For sanity, even better would be:

@PART[*]:HAS[@MODULE[ModuleConfigurableAntenna],!MODULE[ModuleRealAntenna]]:AFTER[zzzRealismOverhaul]
{
	@MODULE[ModuleConfigurableAntenna]
	{
		@name = ModuleRealAntenna
	}
}

@Gordon-Dry
Copy link
Contributor Author

Gordon-Dry commented Aug 7, 2019

See my branch's commits to better understand why:
https://github.com/Gordon-Dry/RealismOverhaul/commits/TEST
especially
Gordon-Dry/RealismOverhaul@f4d886a

@DRVeyl
Copy link
Owner

DRVeyl commented Aug 7, 2019

Accepted and merged.

@DRVeyl DRVeyl closed this as completed Aug 7, 2019
Capkirk123 pushed a commit to Capkirk123/RealAntennas that referenced this issue Jun 17, 2024
Various changes made to support Σκοπός over the past few years
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants