Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA patch for JNSQ #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 122 additions & 0 deletions GameData/RealAntennas/PlanetPacks/JNSQ.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
// RealAntennas for JNSQ
//
// author: Grimmas
//

@Kopernicus:FOR[JNSQ]:NEEDS[Kopernicus,JNSQ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to BEFORE[JNSQ] or AFTER[JNSQ].
Doing FOR[JNSQ] is a bad practice, since it will declare the JNSQ pass as existing! Thus making NEEDS[JNSQ] always true.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping in line with the other patch structures; RSS does this:

@Kopernicus:FOR[RealSolarSystem_Late]:NEEDS[Kopernicus,RealSolarSystem]

So might be best to use:

@Kopernicus:FOR[JNSQ_Late]:NEEDS[Kopernicus,JNSQ]

It should be fine to declare JNSQ_Late since... nothing should be looking for that. If we want to be overly careful, perhaps JNSQ_RealAntennas

{
@Body[Kerbin]
{
@PQS
{
@Mods
{
!City2[*TrackingStation],* {}
//!City2[GenericTrackingStation],* {}

City2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indenting.

{
name = DSNTrackingStation
objectName = KSC
isKSC = True
lat = -0.01
lon = -91.8
alt = 5
enabled = True
}

City2
{
name = DSNTrackingStation
objectName = Jima Station
isKSC = False
lat = -10
lon = 47
alt = 5
enabled = True
}

City2
{
name = DSNTrackingStation
objectName = Saishou Station
isKSC = False
lat = -12
lon = -28
alt = 0
enabled = True
}

City2
{
name = DSNTrackingStation
objectName = Suna Station
isKSC = False
lat = -3
lon = 170
alt = 5
enabled = True
}


City2
{
name = GenericTrackingStation
objectName = Northern Dish
isKSC = False
commnetStation = True
snapToSurface = True
lat = 50
lon = 20
alt = 0
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
enabled = True
}

City2
{
name = GenericTrackingStation
objectName = Southern Dish
isKSC = False
commnetStation = True
snapToSurface = True
lat = -65
lon = 90
alt = 5
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
enabled = True
}

@City2[*TrackingStation],*
{
commnetStation = True
snapToSurface = True
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
}
@City2[*TrackingStation],*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting

{
LOD
{
Value
{
visibleRange = 30000
keepActive = False
model = BUILTIN/Dish
scale = 1.0, 1.0, 1.0
delete = False
}
}
}
}
}
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline after final }

2 changes: 1 addition & 1 deletion GameData/RealAntennas/PlanetPacks/Stock.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Hack: Long :NEEDS[!PlanetPack1,!PlanetPack2,...] statement
// Other option is to rename this file to .disabled, and re-enable in Kopernicus+stock circumstance.

@Kopernicus:FOR[RealAntennas]:NEEDS[!RealSolarSystem]
@Kopernicus:FOR[RealAntennas]:NEEDS[!RealSolarSystem,!JNSQ]
{
@Body[Kerbin]
{
Expand Down