Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated the render_as_doctags with the new arguments from docling-core #93

Merged
merged 8 commits into from
Sep 23, 2024
Merged

fix: updated the render_as_doctags with the new arguments from docling-core #93

merged 8 commits into from
Sep 23, 2024

Conversation

PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Sep 20, 2024 •
edited
Loading

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@PeterStaar-IBM
updated the render_as_doctags with the new arguments from docling-core
086fbd5 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM
ensuring that docling-core is >1.5.0 to accomodate with the latest ex…
a44c4c0 
…port-to-doctags parameters

Signed-off-by: Peter Staar <taa@zurich.ibm.com>
PeterStaar-IBM and others added 5 commits September 21, 2024 06:26
@PeterStaar-IBM
added the doctags tests
cb3d23b 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@PeterStaar-IBM
updated the README
8df7afa 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@dolfim-ibm
fix poetry lock
5285017 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@cau-git
Fix formatting problems
e57e223 
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
@PeterStaar-IBM
fixed the doctag export in docling/utils/export.py
08cee99 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
@cau-git cau-git marked this pull request as ready for review September 23, 2024 17:11
cau-git
cau-git previously approved these changes Sep 23, 2024
View reviewed changes
@cau-git cau-git dismissed their stale review September 23, 2024 17:15

missing stuff

@dolfim-ibm
propagate xsize and ysize
43f8b91 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
Copy link
Contributor

Note about the updates in the tests results.

  • .json: the new serialization is 1) changing the order of some keys in the dictionaries, 2) some optional keys are now included with default null value.
  • .doctags: this exposes the new richer output provided by the revisited exporter

@dolfim-ibm dolfim-ibm merged commit 4794ce4 into main Sep 23, 2024
4 checks passed
@dolfim-ibm dolfim-ibm deleted the dev/update-export-to-doctags branch September 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfim-ibm dolfim-ibm dolfim-ibm approved these changes

@cau-git cau-git cau-git left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterStaar-IBM @dolfim-ibm @cau-git