This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Typing #68
Merged
Typing #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… leaked into auth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCharm's Python language server doesn't really handle the decorators, so instead I tried VS Code, which uses Pyright for the Pylance plugin, which is much better. To actually exhaustively typecheck, I finally added types everywhere to support mypy. This uncovered some issues, so this also includes some refactoring.
Most notably, the way that the userdata subclassing from how it was used in auth (which needs it for the ID token) has been changed. There is now the IdUserData class, which contains all necessary behavior. This prevented a lot of generic magic that would have been necessary to support the old way in a type-safe manner.
Tests still need to be fixed.
Closes #41.