feat: Add a feedback form #1751
Open
+2,161
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit 3127edb. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
+ Coverage 84.18% 84.31% +0.13%
==========================================
Files 186 193 +7
Lines 6159 6344 +185
Branches 677 693 +16
==========================================
+ Hits 5185 5349 +164
- Misses 826 846 +20
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
zusorio
force-pushed
the
feedback-form
branch
4 times, most recently
from
09e1541
to
516d96a
Compare
|
Thanks for the PR! I hope that I'll find some time tomorrow to review it :) |
zusorio
force-pushed
the
feedback-form
branch
3 times, most recently
from
85c299a
to
3314044
Compare
|
Note that the switch to Material Symbols in #1798 changed the sentiment icons. The names do still exist, but look more intense. If it's merged, the icons here should be updated as following: |
zusorio
force-pushed
the
feedback-form
branch
from
3314044
to
077618c
Compare
This has been done now |
zusorio
force-pushed
the
feedback-form
branch
from
077618c
to
2420ec5
Compare
|
I've added tracking for where the feedback dialog was triggered |
zusorio
force-pushed
the
feedback-form
branch
2 times, most recently
from
2c60f88
to
77fdf0e
Compare
Add a feedback form that can be triggered after terminating a session, on a session card, in regular intervals, and in the footer. Feedback can optionally contain freeform text and include the users contact information. Feedback includes an anonymized version of any associated sessions. Closes #1742
MoritzWeber0
added a commit
that referenced
this pull request
Sep 18, 2024
MoritzWeber0
force-pushed
the
feedback-form
branch
from
77fdf0e
to
b9f9af6
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
added a commit
that referenced
this pull request
Sep 19, 2024
MoritzWeber0
force-pushed
the
feedback-form
branch
from
b9f9af6
to
c6ec85a
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
added a commit
that referenced
this pull request
Sep 19, 2024
MoritzWeber0
force-pushed
the
feedback-form
branch
from
c6ec85a
to
4d3e8de
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
feedback-form
branch
from
4d3e8de
to
8d34386
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -44,6 +44,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-backend | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -30,7 +30,8 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-backend-postgres | |||
| {{ if .Values.docker.images.postgres }} | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -21,6 +21,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-docs | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -39,6 +39,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-frontend | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -35,6 +35,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: grafana | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -41,6 +41,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-guacamole-guacamole | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -39,6 +39,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-guacamole-guacd | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -35,6 +35,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-guacamole-postgres | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -29,6 +29,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: {{ .Release.Name }}-prometheus-nginx | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
| @@ -29,6 +29,7 @@ | |||
| {{- include "capellacollab.pod.spec" . | indent 6 -}} | |||
| containers: | |||
| - name: prometheus | |||
| {{- include "capellacollab.container.spec" . | indent 10 -}} | |||
Check warning
Code scanning / SonarCloud
Storage limits should be enforced
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
feedback-form
branch
from
8d34386
to
68829c1
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
feedback-form
branch
from
68829c1
to
ee18368
Compare
- Add SMTP mock for local development (in cluster and in dev-mode) - Change to newer Python syntax, e.g. `t.Optional` -> `| None` - Outsource email sending to it's own module, it will be relevant for other parts as well - Import modules and not classes or functions directly. - Remove the anonoymity policy and feedback percentage for simplicity and determinism. - Auto-disable feedback if SMTP is not set, decline enabling with disabled SMTP - Decline enabling feedback with empty list of recipients - Reduce the verbosity of the AnonymizedSession. It did include the whole tool config before. - Rename receivers to recipients. - Add more Stories and pytests. - Add storage limits to all containers (suggested by SonarCloud) - Change some error codes from Server errors to Client errors - Disable footer feedback button if not logged in.
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
feedback-form
branch
from
ee18368
to
79385b3
Compare
|
|
This report was generated by comparing 3127edb with 9715d90. ArtifactName:
|
| item | count |
|---|---|
| pass | 210 |
| change | 34 |
| new | 14 |
| delete | 0 |
📝 Report
Differences
General Components_Footer_General_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Footer_General_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Error State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Error State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed Scheduling State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed Scheduling State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Killing State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Killing State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Network Issues State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Network Issues State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pulled State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pulled State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pulling State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pulling State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Queued State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Queued State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Scheduled State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Scheduled State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Stopped State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Stopped State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Success State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Success State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Warning State Story_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Warning State Story_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
New Items
General Components_Footer_With Feedback Enabled_desktop.png
 |
General Components_Footer_With Feedback Enabled_mobile.png
 |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
 |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
 |
Session Components_Feedback_No Sessions_desktop.png
 |
Session Components_Feedback_No Sessions_mobile.png
 |
Session Components_Feedback_One Session With User Information_desktop.png
 |
Session Components_Feedback_One Session With User Information_mobile.png
 |
Session Components_Feedback_One Session_desktop.png
 |
Session Components_Feedback_One Session_mobile.png
 |
Session Components_Feedback_Rating Selected_desktop.png
 |
Session Components_Feedback_Rating Selected_mobile.png
 |
Session Components_Feedback_Two Sessions_desktop.png
 |
Session Components_Feedback_Two Sessions_mobile.png
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feedback form that can be triggered after terminating a session, on a session card, in regular intervals, and in the footer. Feedback can optionally contain freeform text and include the users contact information. Feedback includes an anonymized version of any associated sessions.
Closes #1742