chore: Update font stack #1798
Merged
chore: Update font stack #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit 1897237. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 186 186
Lines 6144 6144
Branches 676 676
=======================================
Hits 5165 5165
Misses 831 831
Partials 148 148 ☔ View full report in Codecov by Sentry. |
zusorio
force-pushed
the
update-font-stack
branch
2 times, most recently
from
2461272 to
9697056
Compare
Get fonts from fontsource: Removes requirements to check in fonts while still self-hosting them. Fonts can also receive updates through npm. Use Roboto in addition to the standard tailwind font stack: Instead of falling back to only Helvetica Neue and sans-serif, use the tailwind defaults if other fonts could not be loaded. Add the bold (700) variation of Roboto: Previously, browsers were approximating the bold version. This caused some weird font rendering issues on bold text. Move to Material Symbols: Google's old icon font (Material Icons) is deprecated. Theoretically, Material Symbols also supports a variable version with customizable fill, weight, etc but as this version is 3MB, I've decided to go with a static version of it. Closes #1744
zusorio
force-pushed
the
update-font-stack
branch
from
9697056 to
dd4a633
Compare
|
MoritzWeber0
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get fonts from fontsource: Removes requirements to check in fonts while still self-hosting them. Fonts can also receive updates through npm.
Use Roboto in addition to the standard tailwind font stack: Instead of falling back to only Helvetica Neue and sans-serif, use the tailwind defaults if other fonts could not be loaded.
Add the bold (700) variation of Roboto: Previously, browsers were approximating the bold version. This caused some weird font rendering issues on bold text.
Move to Material Symbols: Google's old icon font (Material Icons) is deprecated. Theoretically, Material Symbols also supports a variable version with customizable fill, weight, etc but as this version is 3MB, I've decided to go with a static version of it.
Closes #1744