refactor: Apply changes from code review

capella_rm_bridge/changeset/actiontypes.py

@@ -45,7 +45,7 @@ class InvalidTrackerConfig(Exception):
 class WorkItem(te.TypedDict, total=False):
     """A workitem from the snapshot."""
 
-    id: te.Required[int]
+    id: te.Required[str | int]
     long_name: str
     text: str
     type: str

capella_rm_bridge/changeset/change.py

@@ -1117,6 +1117,7 @@ def attribute_value_mod_action(
             self.model, f"{id} {req_type_id}", deftype, below=self.reqt_folder
         )
         attr = req.attributes.by_definition(attrdef, single=True)
+        assert attrdef is not None
         if isinstance(attr, reqif.EnumerationValueAttribute):
             assert isinstance(valueid, list)
             actual = set(attr.values.by_identifier)

capella_rm_bridge/changeset/find.py

@@ -31,6 +31,6 @@ def find_by(
 
 def find_by_identifier(
     model: capellambse.MelodyModel, id: str, *xtypes: str, **kw
-) -> reqif.ReqIFElement:
+) -> reqif.ReqIFElement | None:
     """Try to return a model object by its ``identifier``."""
     return find_by(model, id, *xtypes, **kw)

docs/source/snapshot.rst

@@ -208,8 +208,9 @@ are supported:
   calculation.
 
 With the ``children`` key the hierarchical structure of the workitems is
-exported and empty children will result in a ``Requirement``. Conversely
-non-empty children will cause change action on a ``Folder``.
+exported. The existance of a ``children`` key will result in a ``Folder``.
+Conversely if there is no ``children`` key will cause change action on a
+``Requirement``.
 
 Complete snapshot
 =================

tests/test_changeset.py

@@ -436,8 +436,8 @@ def test_faulty_simple_attributes_log_AttributeError(
         titem = tracker["items"][0]
         titem["imagination"] = 1
         message_end = (
-            "Invalid module 'project/space/example title'. Invalid "
-            "workitem 'REQ-001'. imagination isn't defined on Folder"
+            "Invalid module 'project/space/example title'. Invalid workitem "
+            "'REQ-001'. 'Folder' object has no attribute 'imagination'"
         )
 
         with caplog.at_level(logging.ERROR):