Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite tests for collectors and layouting #204

Open
ewuerger opened this issue Jan 29, 2025 · 0 comments
Open

Rewrite tests for collectors and layouting #204

ewuerger opened this issue Jan 29, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ewuerger
Copy link
Member

Currently we test the collection and layouting in the same tests and just assert that there was no Exception during these steps. That is a good integration test but we should also start to test the cached ELKInput against predefined inputs (expected). Then we clearly see the effects of refactorings on collectors.
@ewuerger ewuerger added the enhancement New feature or request label Jan 29, 2025
@micha91 micha91 mentioned this issue Jan 29, 2025
Open
ewuerger added a commit that referenced this issue Jan 30, 2025
@ewuerger
test: Split tests
f8cd70e 
Goes into #204
@ewuerger ewuerger mentioned this issue Jan 30, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ewuerger