Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context-diagram): Add cycle detection #155

Merged
merged 2 commits into from
Nov 4, 2024
Merged

feat(context-diagram): Add cycle detection #155

merged 2 commits into from
Nov 4, 2024

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Oct 31, 2024 •
edited
Loading

Cycles would end up in duplicated exchanges and faulty movement to the owner box.

image

@ewuerger ewuerger requested a review from vik378 as a code owner October 31, 2024 15:01
@ewuerger ewuerger self-assigned this Oct 31, 2024
@ewuerger ewuerger added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
huyenngn
huyenngn approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@huyenngn huyenngn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 6803f51 into main Nov 4, 2024
13 checks passed
@ewuerger ewuerger deleted the feat-add-cycle-detection branch November 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenngn huyenngn huyenngn approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees

@ewuerger ewuerger

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @huyenngn