-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use custom collector for default context #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
huyenngn
commented
Jan 15, 2025
•
edited
Loading
edited
- collects target's children's context for context diagram (resolves White Box view/mode - Merge context diagrams #176)
- exchanges between context components are collected (display_actor_relation)
- blackbox view (resolves Black Box view/mode - Default context diagram mode #177)
- fixes edge routing
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 15, 2025 13:47
13c637c
to
f1202e8
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 15, 2025 14:33
f1202e8
to
43722e1
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 16, 2025 02:45
937c79d
to
3335648
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 21, 2025 10:52
1e108f6
to
ee1ca7e
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 22, 2025 10:00
26ca40d
to
952169a
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 22, 2025 10:03
952169a
to
3cf9088
Compare
huyenngn
force-pushed
the
refactor-default-collector
branch
from
January 23, 2025 08:45
e792d85
to
c3d473d
Compare
ewuerger
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug with the labels not being placed in the center of the box anymore.
There is a bug with derived context. The ports are there, but the edges and targets are not.
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.