Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: 외출신청자 조회 API 리팩토링 #123

Merged
merged 11 commits into from
Jan 7, 2024
Merged

🔀 :: 외출신청자 조회 API 리팩토링 #123

merged 11 commits into from
Jan 7, 2024

Conversation

jeongho1209
Copy link
Member

  • 중복되는 부분 분리
  • common, global 패키지 통합
  • config 관련 패키지 통합

@jeongho1209 jeongho1209 added chore 자잘한 수정을 나타냅니다. 리팩토링 리팩토링이 필요함을 나타냅니다. labels Jan 7, 2024
@jeongho1209 jeongho1209 self-assigned this Jan 7, 2024
@jeongho1209 jeongho1209 requested a review from alsco39 January 7, 2024 10:34
alsco39
alsco39 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@alsco39 alsco39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint 해결하고 merge하면 될 것 같습니다!

@jeongho1209 jeongho1209 merged commit f0dc850 into main Jan 7, 2024
0 of 2 checks passed
@jeongho1209 jeongho1209 deleted the refactor-get-picnic-application branch January 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsco39 alsco39 alsco39 approved these changes

@eogus2513 eogus2513 Awaiting requested review from eogus2513 eogus2513 is a code owner

@lyutvs lyutvs Awaiting requested review from lyutvs lyutvs is a code owner

@jaemin05 jaemin05 Awaiting requested review from jaemin05 jaemin05 is a code owner

Assignees

@jeongho1209 jeongho1209

Labels
chore 자잘한 수정을 나타냅니다. 리팩토링 리팩토링이 필요함을 나타냅니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeongho1209 @alsco39