Fix opencascade crashes

DSchroer · Mar 9, 2023 · 294fadd · 294fadd
1 parent cd3414c
commit 294fadd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Use Create, Modify and Remove events for file watcher
 - Order of operations
 - Windows builds crashing randomly
+- Crash on opencascade operations with invalid arguments
 
 ## [v0.0.1] - 2023-02-10
 

diff --git a/crates/opencascade/src/command.rs b/crates/opencascade/src/command.rs
@@ -22,7 +22,11 @@ pub trait Builder<T>: Command {
             pin.pin_mut().build(&progress);
         }
 
-        // SAFETY: safe since is_done and build were checked
-        Ok(unsafe { pin.pin_mut().value() })
+        if !pin.is_done() {
+            Err("opencascade operation failed".into())
+        } else {
+            // SAFETY: safe since is_done and build were checked
+            Ok(unsafe { pin.pin_mut().value() })
+        }
     }
 }