Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoding of some search endpoints and retrieve them via HAL links instead #1069

Open
tdonohue opened this issue Mar 18, 2021 · 0 comments
Open

Remove hardcoding of some search endpoints and retrieve them via HAL links instead #1069

tdonohue opened this issue Mar 18, 2021 · 0 comments
Labels
bug code task component: Discovery related to discovery search or browse system Estimate TBD help wanted Needs a volunteer to claim to move forward low priority

Comments

@tdonohue
Copy link
Member

In DSpace/DSpace#3179 we fixed several broken HAL links in search endpoints. This change did not impact the Angular UI as the UI has hardcoded these links instead of reading them via HAL (this was necessary as the links were broken).

This ticket is simply a reminder that we should review how/where those links are hardcoded in the UI and see if they can be retrieved instead via HAL. It's low priority as the code works perfectly fine as is.
@tdonohue tdonohue added this to the 7.1 milestone Mar 18, 2021
This was referenced Mar 18, 2021
Merged
Merged
@tdonohue tdonohue added bug Estimate TBD low priority component: Discovery related to discovery search or browse system labels Jul 14, 2021
@tdonohue tdonohue removed this from the 7.1 milestone Oct 6, 2021
@tdonohue tdonohue added the help wanted Needs a volunteer to claim to move forward label Oct 6, 2021
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 9, 2023
@tdonohue tdonohue moved this from 🆕 Triage to 👀 Needs Discussion / Analysis in DSpace Backlog Mar 9, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Dec 5, 2023
@NikitaKr1vonosov
Merged in DSC-1408 (pull request DSpace#1069)
358ee7c 
[DSC-1408] - Fix dropdown readonly field

Approved-by: Andrea Barbasso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code task component: Discovery related to discovery search or browse system Estimate TBD help wanted Needs a volunteer to claim to move forward low priority
Projects
DSpace Backlog
Status: 👀 Needs Discussion / Analysis
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdonohue