Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding of i18n files from within a theme #1299

Closed
bbranan opened this issue Aug 26, 2021 · 1 comment · Fixed by #1300
Closed

Support overriding of i18n files from within a theme #1299

bbranan opened this issue Aug 26, 2021 · 1 comment · Fixed by #1300
Labels
needs triage New issue needs triage and/or scheduling new feature
Milestone

Comments

@bbranan
Copy link
Contributor

bbranan commented Aug 26, 2021

Is your feature request related to a problem? Please describe.

When applying customizations to the DSpace 7 UI, the majority of all changes can be done from within a theme. This allows for keeping customizations for a site separate from the base/default codebase, which is valuable for several reasons. Unfortunately, it is not currently possible to maintain this separation for UI label text that resides in the src/assets/i18n directory. These translation files must be edited in place, which is a departure from the theme model.

Describe the solution you'd like

The ideal solution would be to allow creating files in src/themes/{my-theme}/assets/i18n that are used to override specific i18n label values. The file names could be required to match between the two i18n directories, to support updating any language. Only the labels to be updated should be needed in the theme, not a full copy of the translation file.

Describe alternatives or workarounds you've considered

The immediate workaround is to update translation files directly within the top-level src/assets/i18n directory.

@bbranan bbranan added needs triage New issue needs triage and/or scheduling new feature labels Aug 26, 2021
bbranan added a commit to bbranan/dspace-angular that referenced this issue Aug 26, 2021
@mwoodiupui
Copy link
Member

Let me add weight to the desire to override specific catalog entries, not just copy the whole catalog and hack it. We have done something similar with XMLUI and I find it much easier to work with just our changed texts.

@artlowel artlowel linked a pull request Sep 1, 2021 that will close this issue
6 tasks
@tdonohue tdonohue added this to the 7.1 milestone Sep 9, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Feb 12, 2024
Authority source DSC-1498

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage New issue needs triage and/or scheduling new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants